Fix Android x86 Architecture name #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a x86 project, the folder inside lib is named i686. However Android x86 actually expects the folder to be called x86.
|
@IsaacTCB thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
When using the Android.Makefile that is inside examples for building a project, if chosen Android architecture is x86 then the makefile will create a folder inside lib called i686. However, in order to install, Android actually expects this folder to be called x86.
Basically, the lib\i686\ folder should actually be named lib\x86\ in order to be able to install the app on a x86 Android.
The fix
In order to fix this, I just changed the ANDROID_ARCH_NAME variable from i686 to x86.
Notes